Standardize TCK formatting #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mswatosh
approved these changes
Aug 11, 2023
| * @param min minute | ||
| * @param h hour | ||
| * @param d day | ||
| * @param l ?? |
There was a problem hiding this comment.
int d = Arrays.binarySearch(daysOfMonth, dayOfMonth);
int l = Arrays.binarySearch(daysOfMonth, dayOfMonth - lastDayOfMonth - 1);
I did some digging, and from what I see, d isn't (exactly) the day, it's the index of the day in the daysOfMonth array. And l is the offset from the last day of the month in the daysOfMonth array.
There was a problem hiding this comment.
I opened #318 to address these, so they don't need to be addressed here.
| * @param d day | ||
| * @param l ?? | ||
| * @param dayOfMonth day of month | ||
| * @param m minute |
There was a problem hiding this comment.
int m = Arrays.binarySearch(months, time.getMonthValue());
like above, m is the index of the month in the months array. None of these need to be updated now, but we may want to open an issue to refactor some of this for maintainability
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the maven-checkstyle-plugin on the TCK and ensure formatting between contributors.
The current TCK which was mostly copied from the Platform-TCK has a mix of tabs and spaces, along with a bunch of other non-standard formatting issues.
Also had to fix some bugs in the signature testing logic, which should all be resolved by the last two commits.