Adding Flow Subscriber APIs to ContextService #368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking to get feedback on adding these two new APIs to Context Service. After investigation the Flow classes added in Java 9, what I believe would be the most useful addition for Concurrency is providing context on the Flow.Subscriber methods. The new Flow class consists of:
Flow.Publisher
Flow.Subscription
Flow.Subscriber
Flow.Processor
From what I can tell,
Flow.Publisher
's methods would generally be invoked where context is available, andFlow.Subscription
doesn't have methods where context would add value.Flow.Subscriber
is where context could be useful, because it's methods may or may not be called asynchronously.Flow.Processor
extendsFlow.Publisher
andFlow.Subscriber
, which is why I provided an API to contextualize it'sFlow.Subscriber
methods.Let me know your thoughts, or if there's something else we should be considering here.