Jakarta Tags 3.0 Spec #457

volosied · 2022-02-24T16:06:14Z

Specification PR template

When creating a specification project release review, create PRs with the content defined as follows.

Include the following in the PR:

Note: If any item does not apply, check it and mark N/A below it.

netlify · 2022-02-24T16:16:12Z

✅ Deploy Preview for jakartaee-specifications ready!

Name	Link
🔨 Latest commit	`90f4809`
🔍 Latest deploy log	https://app.netlify.com/sites/jakartaee-specifications/deploys/627d7002085d9c00088a8859
😎 Deploy Preview	https://deploy-preview-457--jakartaee-specifications.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

volosied · 2022-03-10T21:47:58Z

Reminder: jakartaee/platform-tck#882 (comment)

starksm64 · 2022-04-06T16:19:23Z

Spec Review Checklist (Mentor)

Spec PR

_index.md

Link to project release plan of the form https://projects.eclipse.org/projects/ee4j.{spec}/releases/x.y/plan
Link to spec pdf
Link to spec html
Link to apidocs
Link to final TCK download zip file of the form https://download.eclipse.org/jakartaee/{spec}/x.y/*{spec}-tck-x.y.z.zip (The folder path is required, the file name pattern is preferred.)
Link to API jar file of the form https://search.maven.org/artifact/jakarta.{spec}/jakarta.{spec}-api/x.y.z/jar
Name of and link to at least one Compatible Implementation
Review summary statement to ensure it has been updated to reflect the work accomplished and does not contain proposal statements as might be found in Plan Review statement.

javadocs

Footer contains Eclipse copyright and link to license
ESFL license is included, usually as doc-files/speclicense.html
no META-INF directory in PR
javadocs-jar artifact matches apidocs (optional for this release)

Spec PDF

Spec HTML

Same as PDF

TCK zip file

README file (optional for this release)
EFTL license file, preferably named LICENSE.md
User's Guide (or equivalent documentation)
How to test the Compatible Implementation(s) listed in _index.md above with the TCK (may be in UG)

TCK User's Guide (or equivalent documentation)

Software requirements listed
Installation and configuration described
How to run tests
Where to file challenges

Compatibility certification request

Request follows template
SHA-256 fingerprint matches staged TCK zip file
Request issue has certification label.

TCK results summary

Page is hosted by Compatible Implementation project
Includes all information from certification request
Summary includes number of tests passed, failed, errors
SHA-256 fingerprint matches staged TCK zip file on cert request

If a Release Review is required, the specification project team contacts the EMO to initiate the review by sending an email to emo@eclipse.org.
(A Release Review is not required if the current release is a Service Release based on a previously successful Major or Minor
release as indicated by a release record on the project's Releases page, e.g., the Jakarta Servlet releases page.)
- An issue will be created by the EMO to track the release review.
- The specification project team requests approval for the release from the PMC by sending an email to ee4j-pmc@eclipse.org.
- The specification project team then delivers an IP Log to the IP Team for their review as described in https://www.eclipse.org/projects/handbook/#pmi-commands-iplog.
Update Jakarta EE API jar

Update the Jakarta EE API jar by submitting a PR to the jakartaee-api project that updates the version number of your API jar file.

starksm64 · 2022-04-06T16:38:50Z

@volosied the specification pdf and html are using DRAFT as their status. Can you update these to either have no status line or Final?

volosied · 2022-04-11T19:54:05Z

@starksm64 Just updated them to final.

Fix index.md Add back TCK digests Update Jakarta Tags Spec to FINAL Update to 3.0.0 api docs

volosied · 2022-04-20T15:28:19Z

@starksm64

Staging repository link of the form https://jakarta.oss.sonatype.org/content/repositories/staging/jakarta/{spec}/jakarta.{spec}-api/x.y.z/

Here's the link: https://jakarta.oss.sonatype.org/content/repositories/staging/jakarta/servlet/jsp/jstl/jakarta.servlet.jsp.jstl-api/3.0.0/

Should this be check-marked? or is something incorrect?

The Jakarta Tags TCK is passing. How can I move forward with it? (Zip, test results, etc)

TCK results summary
TCK zip file
EFTL TCK link of the form http://download.eclipse.org/.../+.zip
Compatibility certification link of the form https://github.com/eclipse-ee4j/{project}/#{issue}

volosied · 2022-04-20T15:32:56Z

Scott posted this -- jakartaee/platform-tck#886 (comment)

starksm64 · 2022-04-20T16:14:29Z

So now what is needed is a candidate TCK bundle and a CCR for a canidate GlassFish release. Let me ask @scottmarlow about that.

scottmarlow · 2022-04-20T18:27:09Z

So now what is needed is a candidate TCK bundle

Standalone TCK http://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl//jakarta-tags-tck-3.0.0.zip was updated today and the nightly GlassFish build (https://download.eclipse.org/ee4j/glassfish/glassfish-7.0.0-SNAPSHOT-nightly.zip) passed.

and a CCR for a canidate GlassFish release. Let me ask @scottmarlow about that.

Test results are here but not in CCR form: https://ci.eclipse.org/jakartaee-tck/job/10/job/eftl-standalonetck-build-run-100/106/artifact/results/junitreports/tags-tck-junit-report.xml/*view*/

From looking for previous CCRs via https://github.com/eclipse-ee4j/jstl-api/issues?q=is%3Aissue+is%3Aclosed+compatibility+label%3Acertification, I see that the last CCR jakartaee/tags#126 referred to TCK results copied to https://eclipse-ee4j.github.io/jstl-api/certifications/jakarta-tags/2.0/TCK-Results

arjantijms · 2022-04-21T15:24:15Z

CCR: jakartaee/tags#226

volosied · 2022-04-22T15:04:44Z

@arjantijms @starksm64 What are the next steps for the CCR? Also, what about the other items in the checklist list?

Updated release record (can someone explain this more in detail?)
Generated IP Log (How do we do this?)
Email to PMC
Start release review by emailing EMO

Thanks!

arjantijms · 2022-04-22T17:04:16Z

You can generate the IP log via the Eclipse project page. There's a link for it on the right side of the page. The preview looks like this: https://projects.eclipse.org/projects/ee4j.jstl/releases/3.0.0/iplog/preview

IP log: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=24062

arjantijms · 2022-04-22T17:27:57Z

PMC Mail: https://www.eclipse.org/lists/ee4j-pmc/msg03320.html

tags/3.0/_index.md

starksm64 · 2022-04-25T17:57:37Z

This looks good to me. Has the EMO contacts @arjantijms with their tracking issue? They usually do this when you file the IP log.

volosied · 2022-04-25T18:15:31Z

@starksm64 @arjantijms Please let me know if I can do anything to help. I'm not sure what else specifically needs to be done / followed up on. Thanks again for all your help!

starksm64 · 2022-04-25T18:21:32Z

@volosied this looks ready to go to ballot to me, so I have asked @Emily-Jiang to start the ballot. That is the next step in the release process.

arjantijms · 2022-04-26T17:30:08Z

Release review tracking issues: https://gitlab.eclipse.org/eclipsefdn/emo-team/emo/-/issues/277

volosied · 2022-05-03T19:56:46Z

tags/3.0/_index.md

@@ -9,7 +9,7 @@ for manipulating XML documents, internationalization tags, and SQL tags. It also
 existing custom tags with Jakarta Standard Tag Library tags.

 * [Jakarta Standard Tag Library 3.0 Release Record](https://projects.eclipse.org/projects/ee4j.jstl/releases/3.0.0)


@ivargrimstad Wanted to address your comments mentioned here: https://www.eclipse.org/lists/jakarta.ee-spec/msg02435.html

I should remove this Release Record above?

volosied · 2022-05-03T20:00:00Z

tags/3.0/_index.md

 The plan for the release is to clean up open issues:
 * General specification document cleanup.
-* Clean up issues found during the Jakarta EE9 review ballot process: update if possible the tagdocs to include EFSL, Update tlddoc generation if possible to jakarta.
+* Clean up issues found during the Jakarta EE9 review ballot process
+* Update tagdocs to include EFSL
+* Update tlddoc generation to jakarta.
 * Remove any deprecated methods from the API if they exist.
 * Rename java.sun.com / xmlns.jcp.org taglib URIs to new jakarta.tags.\* URNs. [Issue 144](https://github.com/eclipse-ee4j/jstl-api/issues/144)
    * This alone should require a major release.
 * Other small clean up issues


@ivargrimstad
Should I update this section to list a Release Summary (and include list of changes) or should I just remove entire section?

Pages 3.1 and a few others, for example, don't include a Plan or other summary.

https://deploy-preview-435--jakartaee-specifications.netlify.app/specifications/pages/3.1/

volosied · 2022-05-03T20:06:34Z

tags/3.0/_index.md

@@ -48,7 +51,7 @@ The following TCK updates will be required:
 * [Jakarta Standard Tag Library 3.0 Release Record](https://projects.eclipse.org/projects/ee4j.jstl/releases/3.0.0)

 # Compatible Implementations
-* [EE4J implementation of Jakarta Standard Tag Library 3.0.0](https://github.com/eclipse-ee4j/jstl-api/releases/download/3.0.0-IMPL-RELEASE/jakarta.servlet.jsp.jstl-3.0.0.jar) using vehicle [Eclipse Glassfish x.0.0-x](https://github.com/eclipse-ee4j/glassfish/releases/download/)
+* [EE4J implementation of Jakarta Standard Tag Library 3.0.0](https://github.com/eclipse-ee4j/jstl-api/releases/tag/3.0.0-IMPL-RELEASE)


FYI: Updated this to say our latest impl (as that's what was used against the TCK)

volosied · 2022-05-09T20:35:56Z

tags/3.0/_index.md

+This release includes the following changes:
+* Renamed Tag URIs to 'jakarta.tags.*'
+* Updated Jakarta Tags to Java 11
+* Added JPMS Module Info Class
+* Removed dependency on XML Binding from the API pom
+* Updated tagdocs to include EFSL
+* Updated tlddoc generation to support jakarta.
 * General specification document cleanup.
-* Clean up issues found during the Jakarta EE9 review ballot process
-* Update tagdocs to include EFSL
-* Update tlddoc generation to jakarta.
-* Remove any deprecated methods from the API if they exist.
-* Rename java.sun.com / xmlns.jcp.org taglib URIs to new jakarta.tags.\* URNs. [Issue 144](https://github.com/eclipse-ee4j/jstl-api/issues/144)
-    * This alone should require a major release.
-* Other small clean up issues
+


@ivargrimstad @Emily-Jiang Let me know how this looks per the comments found in the ballot. Thanks!

For some other specs I added the GitHub issues where appropriate:

https://github.com/jakartaee/specifications/pull/460/files#diff-031c5337b39b2a8d742e677df77f3a099cb906519800f4800b72b30af8e782bd

https://github.com/jakartaee/specifications/pull/461/files#diff-c93f4dcb13475d9a13f9dc8e92dbd2e0b289f20dc9d06d7c319c3d544b0cc7c5

https://github.com/jakartaee/specifications/pull/459/files#diff-442cedce2cdf5cc01aea2bcfe1dc928904c68c0477da2dea9f07f7d3d2c991b2

Might be good for consistency (although not required of course) to have somewhat of the similar format?

I added links to the changes labeled under Changed between Jakarta Standard Tag Library 2.0 and Jakarta Standard Tag Library 3.0

As for the other changes (last 3), there were multiple aspects to it, so I didn't bother adding links.

Emily-Jiang · 2022-05-17T22:05:14Z

On ballot completion, the specification committee mentor:

adds this final checklist to the main PR.
adds the approved label to the PRs, and sends out the Ballot Summary per this template to the public Jakarta EE Specification Committee email list
calculates the staged EFTL TCK signature and promotes it to the committee download area
using the https://ci.eclipse.org/jakartaee-spec-committee/job/promote-release/ job. Manually editing the jenkins Build Information will help identify the build (ie. Mail 2.0 or CDI 3.0).
merges the specification (and apidocs) PRs, ensuring the "date:" field in the _index.md file has an appropriate value to allow publishing.
updates the specification page with the ballot results. This is normally done via a separate PR that should be reviewed, approved, and merged.
notifies the EMO of the ballot results by email to emo@eclipse-foundation.org. Just forward the ballot summary note sent earlier to the public Spec Committee email list.
creates an issue in the specification project that includes the following checklist for the specification project team:
<issue>

volosied marked this pull request as draft February 24, 2022 16:06

volosied mentioned this pull request Feb 24, 2022

Need draft PR for EE10 jakartaee/tags#213

Closed

volosied force-pushed the tags_3ga branch 2 times, most recently from 4b594f9 to d7689aa Compare February 24, 2022 16:52

volosied changed the title ~~Jakarta Tags 3.0 Draft~~ Jakarta Tags 3.0 Spec Feb 24, 2022

volosied force-pushed the tags_3ga branch from d7689aa to 7354324 Compare February 24, 2022 17:09

ivargrimstad added the release review Use this label on PRs that are filed for release review label Feb 27, 2022

starksm64 mentioned this pull request Mar 4, 2022

Need final API artifact staged for EE10 jakartaee/faces#1642

Closed

volosied force-pushed the tags_3ga branch from 7354324 to 715ca2e Compare March 4, 2022 02:47

volosied mentioned this pull request Mar 10, 2022

JSTL TCK Failures for EE10 (JDK 11 / GlassFish 7) jakartaee/platform-tck#882

Closed

Jakarta Tags 3.0

aed5155

Fix index.md Add back TCK digests Update Jakarta Tags Spec to FINAL Update to 3.0.0 api docs

volosied force-pushed the tags_3ga branch from b2bd59a to aed5155 Compare April 11, 2022 20:01

volosied commented Apr 25, 2022

View reviewed changes

tags/3.0/_index.md Outdated Show resolved Hide resolved

Update tags date

7a5f9d8

volosied marked this pull request as ready for review April 25, 2022 18:55

ivargrimstad added the ballot Delivered to the Specification Committee for ballot label Apr 26, 2022

volosied added 2 commits May 3, 2022 14:43

rename tagsdoc -> tagdoc

abb70f1

Update Compatible Implementations to version 3.0.0

36a3b5c

volosied force-pushed the tags_3ga branch from 20ca0d0 to 36a3b5c Compare May 3, 2022 18:43

volosied commented May 3, 2022

View reviewed changes

Review Updates: Tagdocs

1f7606a

volosied force-pushed the tags_3ga branch from ef7b172 to 1f7606a Compare May 4, 2022 17:29

update _index.md to address ballot review

e4167e1

volosied commented May 11, 2022

View reviewed changes

volosied force-pushed the tags_3ga branch 2 times, most recently from 35b524e to db1c4c9 Compare May 12, 2022 20:36

Add links to github issues

90f4809

volosied force-pushed the tags_3ga branch from db1c4c9 to 90f4809 Compare May 12, 2022 20:37

Emily-Jiang added approved The ballot was approved by the Specification Committee and removed ballot Delivered to the Specification Committee for ballot labels May 17, 2022

Emily-Jiang merged commit 2df4bd0 into jakartaee:master May 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jakarta Tags 3.0 Spec #457

Jakarta Tags 3.0 Spec #457

volosied commented Feb 24, 2022 •

edited by starksm64

Loading

netlify bot commented Feb 24, 2022 •

edited

Loading

volosied commented Mar 10, 2022

starksm64 commented Apr 6, 2022 •

edited

Loading

starksm64 commented Apr 6, 2022

volosied commented Apr 11, 2022

volosied commented Apr 20, 2022

volosied commented Apr 20, 2022

starksm64 commented Apr 20, 2022

scottmarlow commented Apr 20, 2022

arjantijms commented Apr 21, 2022

volosied commented Apr 22, 2022

arjantijms commented Apr 22, 2022

arjantijms commented Apr 22, 2022

starksm64 commented Apr 25, 2022 •

edited

Loading

volosied commented Apr 25, 2022

starksm64 commented Apr 25, 2022

arjantijms commented Apr 26, 2022

volosied May 3, 2022

volosied May 3, 2022

volosied May 3, 2022

volosied May 9, 2022

arjantijms May 11, 2022

volosied May 12, 2022 •

edited

Loading

Emily-Jiang commented May 17, 2022 •

edited

Loading

		@@ -9,7 +9,7 @@ for manipulating XML documents, internationalization tags, and SQL tags. It also
		existing custom tags with Jakarta Standard Tag Library tags.

		* [Jakarta Standard Tag Library 3.0 Release Record](https://projects.eclipse.org/projects/ee4j.jstl/releases/3.0.0)

Jakarta Tags 3.0 Spec #457

Jakarta Tags 3.0 Spec #457

Conversation

volosied commented Feb 24, 2022 • edited by starksm64 Loading

Specification PR template

netlify bot commented Feb 24, 2022 • edited Loading

✅ Deploy Preview for jakartaee-specifications ready!

volosied commented Mar 10, 2022

starksm64 commented Apr 6, 2022 • edited Loading

Spec Review Checklist (Mentor)

starksm64 commented Apr 6, 2022

volosied commented Apr 11, 2022

volosied commented Apr 20, 2022

volosied commented Apr 20, 2022

starksm64 commented Apr 20, 2022

scottmarlow commented Apr 20, 2022

arjantijms commented Apr 21, 2022

volosied commented Apr 22, 2022

arjantijms commented Apr 22, 2022

arjantijms commented Apr 22, 2022

starksm64 commented Apr 25, 2022 • edited Loading

volosied commented Apr 25, 2022

starksm64 commented Apr 25, 2022

arjantijms commented Apr 26, 2022

volosied May 3, 2022

Choose a reason for hiding this comment

volosied May 3, 2022

Choose a reason for hiding this comment

volosied May 3, 2022

Choose a reason for hiding this comment

volosied May 9, 2022

Choose a reason for hiding this comment

arjantijms May 11, 2022

Choose a reason for hiding this comment

volosied May 12, 2022 • edited Loading

Choose a reason for hiding this comment

Emily-Jiang commented May 17, 2022 • edited Loading

volosied commented Feb 24, 2022 •

edited by starksm64

Loading

netlify bot commented Feb 24, 2022 •

edited

Loading

starksm64 commented Apr 6, 2022 •

edited

Loading

starksm64 commented Apr 25, 2022 •

edited

Loading

volosied May 12, 2022 •

edited

Loading

Emily-Jiang commented May 17, 2022 •

edited

Loading