Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update schema #274

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Update schema #274

wants to merge 7 commits into from

Conversation

ag0n1k
Copy link
Contributor

@ag0n1k ag0n1k commented Feb 7, 2021

Hi!

I was surprised that creation collection properties is not yet available. So here it is!

This PR does not provide:

  1. "update" of current properties (change types)
  2. "delete" current properties

So only add new property.

The smoke_tests are fine, but with only "edit" perms there are errors:

  1. The search the whole space does not work
# search the entire space
assert row1 in client.search_blocks(search=special_code)
assert row1 not in client.search_blocks(search="penguins")
assert row2 not in client.search_blocks(search=special_code)
assert row2 in client.search_blocks(search="penguins")
  1. The deletion does not work

Maybe the smoke tests instruction needs update that smoke tests requires admin perms?

Thanks in advance!

@ag0n1k
Copy link
Contributor Author

ag0n1k commented Feb 8, 2021

Okay, suddenly, the update and deletion works well. Take me some time to understand it

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant