-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Changelog helper tool updated #3459
base: main
Are you sure you want to change the base?
Conversation
Suggest that existing post-3.11.0 entries be deleted from Changelog and re-added using this script before sorting. (Not because adding has changed, but I have edited the CHANGELOG entries in a couple of existing merged PRs that didn't have a category label) |
@@ -39,6 +39,8 @@ export GH_REPO=jamulussoftware/jamulus | |||
|
|||
PR_LIST_LIMIT=300 | |||
TRANSLATION_ENTRY_TEXT="GUI: Translations have been updated:" | |||
TRANSLATION_ENTRY_TEXT2="Translations updated from Hosted Weblate" | |||
BUNDLED_QT_UPDATE_TEXT="Build: Updated bundled Qt6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a bunch of these defined in the bump dependencies workflow - it's probably worth covering all of them (separate groups). (It's Build: Updated
+ the changelog_name
value.)
"Android:" | ||
"iOS:" | ||
"Dependencies:" | ||
"Translation:" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should all the translations be together (i.e. up with $TRANSLATION_ENTRY_TEXT
and $TRANSLATION_ENTRY_TEXT2
- or down here with doc and website)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. There are some entries which are sorted by language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Short description of changes
Add improvements to
tools/changelog-helper.sh
:\n
swallowed, making it join to another entry.CHANGELOG: Internal: added improvements to changelog-helper.sh
Context: Fixes an issue?
Addresses some of the suggestions in #3319, but not all of them. Some would need a substantial re-implementation.
Does this change need documentation? What needs to be documented and how?
Not really - internal use only
Status of this Pull Request
Ready for review
What is missing until this pull request can be merged?
Checklist