Fix Pod Term Detection and Make SkipLevels Configurable #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…VENT_LEVELS... - Leaving SKIP_EVENT_LEVELS unset Defaults to old behavior, "normal" type events will be skipped - Setting SKIP_EVENT_LEVELS to empty No event type will be skipped - Setting SKIP_EVENT_LEVELS to a comma separated event type list like "SKIP_EVENT_LEVELS=normal,warning" All events of those types will be skipped. The filtering mechanism is case-insensitive, so "normal,warning" is the same as "nOrMal,WARning".
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @janLo,
regarding your question about the code path being taken I think the implementation was indeed not quite correct. LastTerminationState is the previous state, not the current one. It is set only in cases of restarting containers.
The doc is not very good on that though:
https://v1-17.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.17/#containerstatus-v1-core
See
statevslastStateI also added the feature to configure the skipped event levels.
The change does work properly against my local Sentry 9.1.2 desktop setup.