fix: unload engine before updating #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vansangpfiev
force-pushed
the
fix/unload-engine-before-updating
branch
2 times, most recently
from
02c4da5 to
128757d
Compare
vansangpfiev
force-pushed
the
fix/unload-engine-before-updating
branch
from
128757d to
09682bf
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request includes an important update to the
void Engines::UpdateEngine(function in theengine/controllers/engines.ccfile. The change ensures that the engine is unloaded before updating it.engine/controllers/engines.cc: Added a call toengine_service_->UnloadEngine(engine)to unload the engine before performing the update operation.Fixes Issues
Self Checklist