Fix torch error on misc.CovarianceMatrix #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix inplace operation (pytorch bug)
|
@louisoutin thank you for the PR and sorry it took me so long to have a look:) I will play around with it a little bit (e.g. fixing the CI) and hopefully merge soon:) |
|
@louisoutin Thank you again:) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for the repository and nice documentation.
When running the end_to_end example with BachelierNet, I ran into the following error:
(using torch == 2.1.2 on cpu)
I fixed it by changing the inplace operation in CovarianceMatrix.compute_covariance (misc.py line 136, check the PR change).