Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Type hint optimizer and filter in test_mace and test_7net correctly, fix pickled PatchedPhaseDiagram and compile_wbm_test_set.py #122

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

CompRhys
Copy link
Collaborator

@CompRhys CompRhys commented Aug 7, 2024

Changes to allow pylance to correctly resolve the base class methods when declaring the filter/optimizer from dict

@janosh janosh added the fix Bug fix label Aug 7, 2024
@janosh janosh changed the title maint: type hint optimizer and filter correctly Type hint optimizer and filter in test_mace and test_7net correctly, fix pickled PatchedPhaseDiagram and compile_wbm_test_set.py Aug 7, 2024
@janosh janosh added data Data loading and processing reproducibility Issues or improvements to reproducibility types Type all the things labels Aug 7, 2024
@janosh janosh merged commit 8258c5c into main Aug 7, 2024
9 of 10 checks passed
@janosh janosh deleted the tweak-hints-pylance branch August 7, 2024 15:47
@janosh janosh added the mlff Concerning machine learning force fields label Aug 22, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
data Data loading and processing fix Bug fix mlff Concerning machine learning force fields reproducibility Issues or improvements to reproducibility types Type all the things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants