Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add metrics analysis excluding WBM materials with duplicate/MP-matching structure prototype #75

Merged
merged 9 commits into from
Jan 25, 2024

Conversation

janosh
Copy link
Owner

@janosh janosh commented Jan 24, 2024

718b2be bump requires-python = ">=3.(9->11)"
17837db WBM df_summary add column wyckoff_spglib from DFT-relaxed structs after renaming prev wyk col to wyckoff_spglib_initial_structure
f598f4e add wbm_summary col Key.uniq_proto
648ff1b drop mace_checkpoint(,1,2) from DataFiles, update wbm_summary = "wbm/2023-12-13-wbm-summary.csv.gz"
d70139a add site/src/figs/metrics-table-uniq-protos.svelte

before (with prototype overlap)

metrics-table

after (without prototype overlap)

metrics-table-uniq-protos

only significant change in metrics is a ~10% increase in DAF for reasons explained in the SI:

i4xdsRwF

…er renaming prev wyk col to wyckoff_spglib_initial_structure
indicating WBM materials with matching prototype in MP or duplicate prototypes in WBM (keeping only the lowest energy one)
add table captions, change clf/regr metrics separator line from dotted to solid
@janosh janosh added enhancement New feature or request analysis New model analysis pkg PyPI package related labels Jan 24, 2024
assert duplicate prototype counts in compile_wbm_test_set.py
print prevalence of stable structures in eda_wbm.py
remove metrics tables captions
fix TNR typos in preprint/+page.md and iclr-ml4mat/+page.md
fix test_data.py expected df_wbm.shape and load() bad key err msg
@janosh janosh force-pushed the mp-wbm-protoptype-overlap branch from fecf195 to bf75c79 Compare January 25, 2024 10:09
@janosh janosh enabled auto-merge (squash) January 25, 2024 10:09
@janosh janosh merged commit a7f693d into main Jan 25, 2024
10 checks passed
@janosh janosh deleted the mp-wbm-protoptype-overlap branch January 25, 2024 10:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
analysis New model analysis enhancement New feature or request pkg PyPI package related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant