-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rough solution to recreating plots for unique proto set #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janosh
force-pushed
the
unique-proto-plots
branch
from
February 7, 2024 12:18
d1850e6
to
1b9e75b
Compare
janosh
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! 👍 refactored to what i hope is slightly more extensible
from matbench_discovery.enums import Key, TestSubset
from matbench_discovery.plots import cumulative_metrics
from matbench_discovery.preds import df_each_pred, df_preds, model_styles, models
test_subset = globals().get("test_subset", TestSubset.full)
if test_subset == TestSubset.uniq_protos:
df_preds = df_preds.query(Key.uniq_proto)
and also controllable via init_globals
in
runpy.run_path(file, init_globals={"which_energy": which_energy}) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checked all the plots when using unique proto subset, nothing stands out as different but attention to detail. The way i've done this is very hammer and nails I think that a cleaner global parameter or something could maybe work better.