-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
missing dependency (html-minifier) #1311
Comments
Thanks for the heads up 👍 will take a look |
Unfortunately I introduced this with #1309 - however all builds were green 🤔 |
My guess is that it's because You should be able to repro this issue if instead of |
Hey @obartra can you please verify that it works now? |
I was using Thanks so much for the quick response 🎉 |
Thanks for your feedback 👍👍 |
Expected behaviour
Webpack build succeeds
Current behaviour
Webpack build fails, requiring "html-minifier" from "html-webpack-plugin"
Manually installing
html-minifier
fixes the issueEnvironment
On
html-webpack-plugin@4.0.0-beta.10
,webpack@4.41.2
,node@12.13.0
,npm@6.12.0
Config
NA
Relevant Links
NA
Additional context
I suspect adding
html-minifier
tohtml-webpack-plugin
dependencies would fix the issue, happy to contribute if that's the desired changeThe text was updated successfully, but these errors were encountered: