Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Use src/index.ejs by default if present #1167

Merged
merged 1 commit into from
Mar 22, 2019

Conversation

jantimon
Copy link
Owner

@jantimon jantimon commented Feb 17, 2019

BREAKING CHANGE: Use src/index.ejs if no template option is set.

Webpack will pick up src/ by default that means depending on your resolving settings it will use src/index.js, src/index.jsx, src/index.ts ... or similar by default.

This pull request adds the same feature for the html-webpack-plugin.

I would love to know what you think in general about this pull request and if we should support:

src/index.ejs
src/index.html
or
public/index.html

cc @sokra @edmorley

BREAKING CHANGE: Use src/index.ejs if no template option is set.
@sokra
Copy link
Contributor

sokra commented Feb 17, 2019

👍

@dennisbot
Copy link

Isn't there a way to support dynamic src folder?, for instance, I'm using app folder to set my static files and entry points, or am I missing something?, any comments are welcome, thank you. 😄

@jantimon jantimon merged commit c27e5e4 into master Mar 22, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 21, 2019
@jantimon jantimon deleted the feature/default-template branch January 2, 2020 11:21
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants