Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Handle err before any logic in promise return by compileTemplate #354

Merged
merged 2 commits into from
Jun 15, 2016
Merged

Handle err before any logic in promise return by compileTemplate #354

merged 2 commits into from
Jun 15, 2016

Conversation

vincent-ng
Copy link
Contributor

ref #353 handle err before any logic in promise return by compileTemplate

@vincent-ng
Update compiler.js
e493348 
ref #353 handle err before any logic in promise return by compileTemplate
@jantimon
Copy link
Owner

please make sure you pass the tests.
why don't you move the existing error handler up?

@jantimon
Copy link
Owner

https://github.com/vincentngthu/html-webpack-plugin/blob/e493348953a6c3903b5e2ad11b314ae4f71af239/lib/compiler.js#L88-L94

@jantimon jantimon merged commit 943c555 into jantimon:master Jun 15, 2016
jantimon added a commit that referenced this pull request Jul 2, 2016
@jantimon
Better error handling (#354)
c6b45b3 
Add some docs
@renovate renovate bot mentioned this pull request Apr 17, 2018
Closed
@lock
Copy link

lock bot commented May 31, 2018

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincent-ng @jantimon