clarify operating systems with available binaries #256
Conversation
This is very much a nit. Feel free to close and discard this PR if you wish. It may also be worth getting rid of this line entirely. It appears that since 0.3.12 there have only been Windows binary releases (excluding one linux one in 0.3.13).
|
For 0.3.16, we seem to only have source releases on GH -- but when doing a release, I am just pushing a tag; then @japaric is doing "something" to add artifacts on GitHub (I don't even know how that works). So probably it would make most sense to just remove the remark about binary releases, and point everyone at crates.io. Could you do that? |
|
Yep! I removed the remark entirely. Let me know id you'd rather link the crates.io page. |
|
Thanks! bors r+ |
256: clarify operating systems with available binaries r=RalfJung a=ayazhafiz This is very much a nit. Feel free to close and discard this PR if you wish. It may also be worth getting rid of this line entirely. It appears that since 0.3.12 there have only been Windows binary releases (excluding one linux one in 0.3.13). Co-authored-by: hafiz <ayaz.hafiz.1@gmail.com> Co-authored-by: ayazhafiz <ayaz.hafiz.1@gmail.com>
Build failed |
|
Ah, this is blocked on getting rust-lang/rust#64444 landed. |
|
bors retry |
256: clarify operating systems with available binaries r=RalfJung a=ayazhafiz This is very much a nit. Feel free to close and discard this PR if you wish. It may also be worth getting rid of this line entirely. It appears that since 0.3.12 there have only been Windows binary releases (excluding one linux one in 0.3.13). Co-authored-by: hafiz <ayaz.hafiz.1@gmail.com> Co-authored-by: ayazhafiz <ayaz.hafiz.1@gmail.com>
Build failed |
|
bors retry |
256: clarify operating systems with available binaries r=RalfJung a=ayazhafiz This is very much a nit. Feel free to close and discard this PR if you wish. It may also be worth getting rid of this line entirely. It appears that since 0.3.12 there have only been Windows binary releases (excluding one linux one in 0.3.13). Co-authored-by: hafiz <ayaz.hafiz.1@gmail.com> Co-authored-by: ayazhafiz <ayaz.hafiz.1@gmail.com>
Build succeeded |
Oh, huh, I thought this was automatic through CI, but it seems this didn't happen for 0.3.16... |
|
I see no indication in our CI that it would do anything like that. But I honestly don't know. I don't even know what it takes to turn a git tag into a GH "release"... not all tags seem to be treated as releases. Whatever.^^ |
|
I was assuming this has something to do with it. If not, I don't understand what the |
|
Hm, yeah. No idea what that part does. And I hope that's not a secret API key we have in that file... |
This is very much a nit. Feel free to close and discard this PR if you wish.
It may also be worth getting rid of this line entirely. It appears that since 0.3.12 there have
only been Windows binary releases (excluding one linux one in 0.3.13).