-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix: return onSubmit promise result in submission #2420
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/jared/formik-docs/a2o45q8zz |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 366dd75:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me barring some minor changes re: dev environment.
I'm not super excited with the formatting changing for the whole file, so maybe it'd be best to only commit those changes which are relevant to this PR. But maybe @jaredpalmer has some thoughts on that.
Can we only format the changed lines? |
If the formatting comes from commit hooks that might be a problem. In sourcetree there is the option to "Bypass commit hooks". I don't think this exists in Github Desktop. If it comes from prettier / vscode then it is as simple as "ctrl/cmd+shift+p -> Save without formatting" or disabling formatting temporarily. |
Thanks for the quick responses - pushed up a new version with just the needed lines modified, formatting was from User level settings on my VSCode - should be taken care of now though |
Any word on when this might get merged? Would love to switch back off of my forked package |
Also interested in seeing this get merged! |
Fixes #2419 , maintaining the value of the user's promise.