Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: return onSubmit promise result in submission #2420

Merged
merged 1 commit into from
May 28, 2020
Merged

Fix: return onSubmit promise result in submission #2420

merged 1 commit into from
May 28, 2020

Conversation

mmartinsky
Copy link
Contributor

Fixes #2419 , maintaining the value of the user's promise.

@vercel
Copy link

vercel bot commented Apr 15, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/jared/formik-docs/a2o45q8zz
✅ Preview: https://formik-docs-git-fork-mmartinsky-master.jared.now.sh

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 15, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 366dd75:

Sandbox Source
Formik TypeScript Playground Configuration
magical-mendel-gjocs Issue #2419

Copy link
Collaborator

@johnrom johnrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me barring some minor changes re: dev environment.

I'm not super excited with the formatting changing for the whole file, so maybe it'd be best to only commit those changes which are relevant to this PR. But maybe @jaredpalmer has some thoughts on that.

@jaredpalmer
Copy link
Owner

Can we only format the changed lines?

@johnrom
Copy link
Collaborator

johnrom commented Apr 15, 2020

If the formatting comes from commit hooks that might be a problem. In sourcetree there is the option to "Bypass commit hooks". I don't think this exists in Github Desktop. If it comes from prettier / vscode then it is as simple as "ctrl/cmd+shift+p -> Save without formatting" or disabling formatting temporarily.

@mmartinsky
Copy link
Contributor Author

Thanks for the quick responses - pushed up a new version with just the needed lines modified, formatting was from User level settings on my VSCode - should be taken care of now though

@mmartinsky
Copy link
Contributor Author

Any word on when this might get merged? Would love to switch back off of my forked package

@cubeghost
Copy link
Contributor

Also interested in seeing this get merged!

@jaredpalmer jaredpalmer merged commit a9dee8a into jaredpalmer:master May 28, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

submitForm not maintaining the result of resolved Promise
4 participants