Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update documentation relative links to include extension #3134

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

gingerrific
Copy link
Contributor

The relative links within the docs for api/formik and [guides/validation](https://formik.org/docs/guides/validation) did not include a .md file extension and the code in rehype-docs.js was expecting one. Due to the lack of extension on these relative doc files, the call to basePath.lastIndexOf('.'); is getting the "dot" in the relative path ../. Simply adding .md to these relative links correctly fixes the routing in the notion documentation

@changeset-bot
Copy link

changeset-bot bot commented Apr 2, 2021

⚠️ No Changeset found

Latest commit: 5a4aafa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 2, 2021

@gingerrific is attempting to deploy a commit to the Formium Team on Vercel.

A member of the Team first needs to authorize it.

@jaredpalmer jaredpalmer merged commit 6d2fce7 into jaredpalmer:master Apr 5, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants