Fix getIn unexpected value #3237
Conversation
As described in jaredpalmer#3181
🦋 Changeset detectedLatest commit: a71a55a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@pieplu is attempting to deploy a commit to the Formium Team on Vercel. A member of the Team first needs to authorize it. |
|
This seems like a good change to me, but we'll definitely want thorough testing when modifying this particular bit of code. |
packages/formik/src/utils.ts
Outdated
| const path = toPath(key); | ||
| while (obj && p < path.length) { | ||
| obj = obj[path[p++]]; | ||
| export function getIn( |
There was a problem hiding this comment.
Looks like the formatting got messed up here. Is this indented correctly?
There was a problem hiding this comment.
You're right, prettier doesn't seem to run automatically. I just fixed it, and added more tests.
|
This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 60 days |
|
up |
|
This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 60 days |
|
We have been using this patch in our application, on the test environment, for a few weeks, no regression found yet. I totally understand that there is a fear with a change in such an important part of Formik, and that it takes time. I will keep you posted when we have deployed this to our production environment. |
|
We have been using this patch in our production environment for almost a month. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 18efee9:
|
As described in #3181
It scares me a bit, touching getIn seems a big change.
But this will correct a bug, rare, but a bug in my opinion