-
Notifications
You must be signed in to change notification settings - Fork 2k
CoffeeScript 1.10.0 #4079
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
CoffeeScript 1.10.0 #4079
Conversation
Running bin/cake doc:site ... and then re-saving index.html ... should normally cause all of those files to be recompiled. (Basically, just working on the index page). However, I think that the file watching thing has been a little hinkey lately. Might make sense to add a task to just recompile them |
Re: changelog -- feel free to elaborate on the bug fixes:
|
Run I can run Still, why are there seemingly duplicate compiled versions? Re: changelog—OK, I’ll add a sublist of really short summaries. |
I’ve updated the PR with summaries of some of the small bug fixes and re-compiled documentation/coffee/*.js files now. I’m still interested in this, though.
|
Sounds good.
They're probably a mistake. We should just delete the copies that aren't being used by index.html. |
Alright. Then I think this PR is good-to-go, unless there are more changelog adjustments requested. I’ll try to remove the unnecessary files in a different PR. |
Published, tagged, pushed. Thanks, @lydell — This was the first 100% no-work painless release I can remember. Nicely done. |
Thanks. However, I didn’t expect this to be merged today, so I set the release date to tomorrow ^^ Does it matter? (Also, I just found a regression in the CSS—I’ll send a PR in a few minutes.) |
Actually, it is not a regression. But the problem is still there. Look at that weird inline code at http://coffeescript.org/#1.10.0. |
Ah, it’s because of the line wrapping in the HTML source code. The easiest thing would be to just not line wrap inside that |
And here’s the PR for removing the duplicate compiled files: #4083. |
Pushed and pushed. You know you can just push those little things yourself, whenever you'd like, if you'd rather... Collaborator status — Long overdue! |
@lydell - Just wanted to say thanks from us users. You've done a ton of valuable stuff lately. |
kudos to @lydell ! keep them coming! 👍 |
I followed the steps I wrote after having made the 1.9.3 PR: https://github.com/jashkenas/coffeescript/wiki/%5BHowto%5D-Hacking-on-the-CoffeeScript-Compiler#11-preparing-a-new-release
Step 8:
However:
I’m very confused by the
documentation/coffee/*.js
files. The various commands I ran seem to have updateddocumentation/js/*.js
, but not the ones in thecoffee
directory. Apparently @jashkenas updated those after my 1.9.3 PR (commit c37f284).It feels like all
documentation/coffee/*.coffee
files have duplicate compiled versions comitted. There seems to be nocake
command to update thedocumentation/coffee/*.js
ones. What’s up here, and which ones are actually used?Regarding the changelog, it might feel really small at only three items, but the last item (”Several minor bug fixes.”) includes a lot of really good fixes. I just didn’t feel necessary to note them all in the changelog, since they don’t affect most CoffeeScript users.
Such a short changelog might also raise the question if we should release a version at all, but remember: