Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update deps to remove warning messages #5479

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cosmicexplorer
Copy link
Contributor

Split out from #5478 so that PR can focus solely on fixing CI.

Problem

Currently we get the following output when running cake test:

Browserslist: caniuse-lite is outdated. Please run:
  npx browserslist@latest --update-db
  Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating

Additionally, executing npm commands currently produces the following output:

9 vulnerabilities (7 high, 2 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Solution

  • Execute npx update-browserslist-db@latest.
    • This is what it tells you to run after executing npx browserslist@latest --update-db as in the warning message.
  • Execute npm audit fix --force.

Result

This changes our puppeter and webpack constraints in package.json to ^ instead of ~. We may instead prefer to stick with ~.

There is also still an additional message produced when executing e.g. npm ci:

npm warn deprecated nomnom@1.5.2: Package no longer supported. Contact support@npmjs.com for more info.

This does not seem to be in our direct dependencies, but would probably be good to resolve at some point in the future.

@cosmicexplorer
Copy link
Contributor Author

Looks like nomnom is from jison: zaach/jison#367. Is there a point of contact for the jison project or is it effectively unmaintained?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant