-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Hotfix for broken builds #2974
Merged
Merged
Hotfix for broken builds #2974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patch-package is a dev dependency and should not be required by users of underscore.js This hotfix removes the postinstall script which is causing multiple build failures across the ecosystem.
@jashkenas bump |
Thank you! |
Will publish as 1.13.6 in a few minutes, hang tight. |
@jashkenas I think I outran you. |
With publishing to NPM, at least. |
I'm preparing a website update now, please let me know where you stand. |
Thanks for jumping in @jgonggrijp — I'll leave things in your hands as to avoid crossing wires. (npm had me locked out on this new laptop, so thanks for pushing the button) |
Alright I'll finish the job. |
jgonggrijp
added a commit
that referenced
this pull request
Sep 23, 2022
jgonggrijp
added a commit
to jgonggrijp/underscore
that referenced
this pull request
Sep 23, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch-package is a dev dependency and should not be required by users of underscore.js
This hotfix removes the postinstall script which is causing multiple build failures across the ecosystem.
See #2967, #2968, #2969, #2970, #2971, #2973