Fix RangeError #11
Open
Fix RangeError #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jeffrafter and thank you for the PR! I'm sorry for the delay. @willglynn this seems better suited for your review when you have time. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason this is happening has something to do with the
_compile_arrayinternals and the problem is solved using emscripten 1.38.32+ and adding the flag-Osor-Oz(https://emscripten.org/docs/optimizing/Optimizing-Code.html#optimizing-code-size) to theemcccall when building the WASM.We also adjusted the memory in this to allow for growth.
cc @damaneice 🍐