Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix credit card expiration date #174

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

antfroger
Copy link
Contributor

Description

Fix credit card expiration date.

The generated expiration dates were in date/month format when they should be in month/year format.
Also, the month generated was between 12 and 30 when it should have been between 1 and 12.

Are you trying to fix an existing issue?

This issue is not reported in github.

Go Version

$ go version
go version go1.22.2 darwin/amd64

Go Tests

$ go test
2024/04/24 17:23:36 Error while requesting https://loremflickr.com/300/200 : request failed
2024/04/24 17:23:36 Error while creating a temp file: temp file creation failed
2024/04/24 17:23:36 Error while requesting https://randomuser.me : request failed
2024/04/24 17:23:36 Error while creating a temp file: temp file creation failed
PASS
ok  	github.com/jaswdr/faker/v2	1.668s

The generated expiration dates were in date/month format, while dates should be in month/year format.
Copy link
Owner

@jaswdr jaswdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaswdr jaswdr merged commit 7b2bfdb into jaswdr:master Apr 25, 2024
17 checks passed
@jaswdr
Copy link
Owner

jaswdr commented Apr 25, 2024

@antfroger thank you very much for the fix, I released it under v2.3.1

@antfroger antfroger deleted the credit-card-expiration-date branch April 25, 2024 11:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants