Uses Golang runtime/debug package to get version info #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 1 of 1 files. Overall, the semantic diff is 7% smaller than the GitHub diff.
|
Signed-off-by: Adam Baxter <git@voltagex.org>
voltagex
force-pushed
the
fix/version-only
branch
from
018505f to
d17fce3
Compare
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the version code to do this: https://github.com/voltagex-forks/dive/blob/eff28ef17026691aa6d4b49f2b893ec6115cb5f8/cmd/version.go
without this patch:
I suspect that once you tag and build it, it'll show the tag version/name.
This uses runtime/debug.
As requested, I split this out of #154