Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: custom collapse behaviour #357

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

12-VidE
Copy link

@12-VidE 12-VidE commented Dec 14, 2024

Pull Request Description

When creating a custom Admotion type, the user can specify its default collapse behaviour

Changes Proposed

  • Added "collapseType" inside the "Admotion" interface to store the preference
  • Added the ablity to select the wanted collapse behaviour when creating a curstom admotion

Related Issues

(Partially) Fixes #335 and a pet-hate of mine

Checklist

  • I have read the contribution guidelines and code of conduct.
  • I have tested the changes locally and they are working as expected.
  • I have added appropriate comments and documentation for the code changes.
  • My code follows the coding style and standards of this project.
  • I have rebased my branch on the latest main (or master) branch.
  • All tests (if applicable) have passed successfully.
  • I have run linters and fixed any issues.
  • I have checked for any potential security issues or vulnerabilities.

Screenshots (if applicable)

...probably not necessary

Additional Notes

Be aware: I'm basically a novice

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insert Custom Callout, with Collapsed by default enabled, not "-" inserted
1 participant