Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bugfix division by zero #23

Merged
merged 5 commits into from
Oct 11, 2019
Merged

bugfix division by zero #23

merged 5 commits into from
Oct 11, 2019

Conversation

Ousret
Copy link
Member

@Ousret Ousret commented Oct 10, 2019

close #22

@Ousret Ousret added the bugfix release Minor release for bug fixes label Oct 10, 2019
@Ousret Ousret self-assigned this Oct 10, 2019
@codecov-io
Copy link

codecov-io commented Oct 10, 2019

Codecov Report

Merging #23 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   83.13%   83.23%   +0.09%     
==========================================
  Files          13       13              
  Lines         854      859       +5     
==========================================
+ Hits          710      715       +5     
  Misses        144      144
Impacted Files Coverage Δ
charset_normalizer/normalizer.py 83.19% <100%> (+0.21%) ⬆️
charset_normalizer/probe_chaos.py 81.87% <100%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92fc6b0...c0a3f32. Read the comment docs.

@Ousret
Copy link
Member Author

Ousret commented Oct 11, 2019

when explain is set to True we can see that utf-16 codec can decode content with two bytes and therefore produce a zero-length str.
Maybe it is a bug.

@Ousret Ousret merged commit 62e32e7 into master Oct 11, 2019
@Ousret Ousret deleted the bugfix-division-zero branch October 11, 2019 06:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bugfix release Minor release for bug fixes
Development

Successfully merging this pull request may close these issues.

[BUG] division by zero
2 participants