Add watchOS 7 and tvOS 14 check for logger #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jayhickey, could you have a look at this PR if you have time? |
jayhickey
requested changes
Oct 2, 2022
There was a problem hiding this comment.
Thanks for the PR @MartinP7r and sorry for the delay! Great catch here, just one additional ask to sync these versions with the Package.swift
| @@ -98,7 +98,7 @@ public final class SyncEngine<Model: CloudKitCodable> { | |||
|
|
|||
| self.logHandler = | |||
| logHandler ?? { string, level in | |||
| if #available(iOS 14.0, macOS 11.0, *) { | |||
| if #available(iOS 14.0, macOS 11.0, watchOS 7.0, tvOS 14.0, *) { | |||
There was a problem hiding this comment.
Mind updating this to match the Package.swift? I think we can do iOS 14.0, macOS 11.0, watchOS 6.0, tvOS 13.0 in both places
There was a problem hiding this comment.
Hi @jayhickey
Logger is only available from watchOS 7.0 and tvOS 14.0 respectively. (reference)
It won't compile otherwise. 🙏🏼
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I just realized you added this check only for some platforms supported in your
Package.swift.