Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Stripe : move customer_data field to metadata #407

Merged

Conversation

fabienheureux
Copy link
Contributor

@fabienheureux fabienheureux commented Apr 10, 2024

Ref #378


In stripe/providers.py the field customer_data does not seem to be defined in Stripe API's Session object

It could be moved to the metadata field (from Stripe's documentation) :

Set of key-value pairs that you can attach to an object. This can be useful for storing additional information about the object in a structured format.

@fabienheureux fabienheureux changed the title move customer_data field to metadata Stripe : move customer_data field to metadata Apr 10, 2024
@fabienheureux fabienheureux marked this pull request as ready for review April 10, 2024 21:03
@WhyNotHugo
Copy link
Member

LGTM.

Needs rebase (has conflicts).

@fabienheureux fabienheureux force-pushed the stripe-move-customer-name-to-metadata branch from fefa4a8 to 3c6177c Compare May 14, 2024 07:55
@fabienheureux fabienheureux requested a review from WhyNotHugo May 14, 2024 08:10
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.42%. Comparing base (8303e09) to head (3c6177c).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #407   +/-   ##
=======================================
  Coverage   78.42%   78.42%           
=======================================
  Files          29       29           
  Lines        1979     1979           
  Branches      244      234   -10     
=======================================
  Hits         1552     1552           
  Misses        310      310           
  Partials      117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WhyNotHugo WhyNotHugo merged commit e6a16fd into jazzband:main Jun 13, 2024
24 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants