-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Enabled parallel tests #757
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #757 +/- ##
=========================================
- Coverage 63.2% 37.9% -25.2%
=========================================
Files 43 44 +1
Lines 3231 3253 +22
Branches 244 244
=========================================
- Hits 2039 1231 -808
- Misses 1175 1778 +603
- Partials 17 244 +227
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the PR is trying to achieve too much at once. Each one of the four items listed in description calls for their own PR. I guess, xdist could be the minimal start point.
@ulgens now I see some issues with overriding I didn't find a way to make I consider going from 5 minutes per env to 1 minute a big improvement tbh so I won't surrender that easily on this PR and try to close it soon 😄 |
@WisdomPill I remember managing similar needs for different projects with relatively simpler changes but apparently I'm missing a set of details. I'm concerned about the project's history: Having a PR with this size and many changes merged into the repo makes it harder for further contributors to understand.
Mad respect there 😄
I'd like to do some testing with xdist and minimal changes before monday if that's okay. I have no info about the urgency of these changes, but my goal is to be back soon with a recommendation or to discard my review. |
Actually the size of the PR is due to the rewrite of
please be my guest, I am open to any improvement and I am really thankful for the time and effort you're spending in the project. You're welcome to propose any changes outside of this PR scope as well, your help is deeply appreciated. |
# Conflicts: # tests/test_client.py
@ulgens I would merge this PR if you don't have any updates |
@WisdomPill I wasn't able to allocate the time I was planning, sorry for that. Please go ahead. |
Many things have been implemented in order to improve tests
pytest_generate_tests
so now they can be run with a singlepytest
commandpytest-xdist
docker-compose
is used to provision the environment for standalone and sentinel setups