Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix getting css_class from self #229

Merged
merged 1 commit into from
Dec 12, 2017
Merged

fix getting css_class from self #229

merged 1 commit into from
Dec 12, 2017

Conversation

PetrDlouhy
Copy link
Contributor

this is needed, if smart selects should work with django-crispy-forms

@coveralls
Copy link

coveralls commented Jul 29, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 88.72% when pulling 1fb0639 on PetrDlouhy:fix_css_class into ae906b9 on digi604:master.

@blag
Copy link
Collaborator

blag commented Nov 17, 2017

Can you explain a bit more how this fixes things?

@cookieofcode cookieofcode mentioned this pull request Dec 5, 2017
Closed
7 tasks
@PetrDlouhy
Copy link
Contributor Author

PetrDlouhy commented Dec 5, 2017 •
edited
Loading

The django-crispy-forms sets css class as widget.attribute:
https://github.com/django-crispy-forms/django-crispy-forms/blob/a4afab25159f229ebc667834609d5ab52d31a491/crispy_forms/templatetags/crispy_forms_field.py#L142
If smart select should work as bootstrap styled input, it needs to get class value of the self.attrs attribute.

@blag blag merged commit e7fe61b into jazzband:master Dec 12, 2017
@blag
Copy link
Collaborator

blag commented Dec 12, 2017

Merged. Thank you for the explanation and the PR!

I'll also cut a new release to PyPI shortly.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PetrDlouhy @coveralls @blag