Create command to remove unused data by checking existing code #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianowa
force-pushed
the
create-waffle-delete-unused
branch
from
1068c07 to
ea82d0c
Compare
clintonb
reviewed
Dec 16, 2023
| def expression_exists(expression): | ||
| for root, dirs, files in os.walk(os.getcwd()): | ||
| for file in files: | ||
| if not (file.endswith(".py") or file.endswith(".html")): #TODO: make this a list of extensions |
There was a problem hiding this comment.
Are you going to do this? Perhaps allow them to be passed in as an optional argument?
| @@ -329,3 +329,44 @@ def test_delete_some_but_not_all_records(self): | |||
|
|
|||
| call_command('waffle_delete', flag_names=[flag_1]) | |||
| self.assertTrue(get_waffle_flag_model().objects.filter(name=flag_2).exists()) | |||
|
|
|||
|
|
|||
| class WaffleDeleteUnused(TestCase): | |||
There was a problem hiding this comment.
These tests aren't really testing the desired behavior—deleting flags. Consider updating the command to take a file path of code to search, and passing that in the test calls to confirm items are deleted.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the issue #492 .
The idea behind it is that in some cases the switches/flags/samples can be automatically removed by checking if they are present in the source code.
Parsing the code for that is implemented directly in Python using the standard lib to maximize compatibility.
The default behavior is to ask for a confirmation in each flag, but there is an override.
I've also checked the messages
./run.sh makemessagesand there were no new ones, so I didn't updated those files.