Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Declare pep517 dependency #1353

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Mar 15, 2021

Fixes #1352

Changelog-friendly one-liner: Declare pep517 dependency

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added bug fix dependency Related to a dependency labels Mar 15, 2021
@atugushev atugushev added this to the 6.0.1 milestone Mar 15, 2021
@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #1353 (c47fb58) into master (3fa72d0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1353      +/-   ##
==========================================
- Coverage   99.65%   99.65%   -0.01%     
==========================================
  Files          33       33              
  Lines        2915     2914       -1     
  Branches      308      308              
==========================================
- Hits         2905     2904       -1     
  Misses          5        5              
  Partials        5        5              
Impacted Files Coverage Δ
piptools/scripts/compile.py 100.00% <100.00%> (ø)
piptools/repositories/pypi.py 97.10% <0.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fa72d0...c47fb58. Read the comment docs.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Member

@vphilippon vphilippon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that makes sense, pep517 would declare the (transitive) dependency on importlib_metadata for Python < 3.8.
And a bit less impact if pip moves this vendored part (not that we are resilient to pip internal changes at all, but that's one thing less :) )
👍

@atugushev atugushev merged commit 079058f into jazzband:master Mar 15, 2021
@atugushev atugushev deleted the declare-pep517-dependency-1352 branch March 15, 2021 16:13
@atugushev
Copy link
Member Author

Thanks @webknjaz, @vphilippon and @astrojuanlu 🙏🏼

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependency Related to a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6.0.0 has an undeclared dependency on importlib-metadata at python 3.6
4 participants