Fix off-by-one error when writing out voxel grid #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a good catch. Thanks for finding this bug. I will see if I can recreate the data in the next days. Fortunately, it should not affect the metrics so much. |
risteon
pushed a commit
to risteon/voxelizer
that referenced
this pull request
Jun 23, 2021
Fix off-by-one error when writing out voxel grid
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing the voxel grids to binary, the
countervariable has an off-by-one error.Besides the invalid memory access at the last vector position, this causes all voxels to be shifted one voxel upwards. Voxels in the top row are additionally shifted horizontally onto the next y-position.
I think that the voxelized annotations from http://semantic-kitti.org/dataset.html#download (downloaded on 2020-06-09) do also exhibit this error.