Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

improvements to assessing curve fit (r2 and rmsd) #57

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Conversation

jbloom
Copy link
Member

@jbloom jbloom commented Mar 25, 2024

Improvements to metrics for assessing curve fit (see here):

  • The coefficient of determination (r2) now is one if all points are fit by a straight line, rather than engative infinity.
  • A root-mean-square-deviation (square root of mean residual) is now calculated as the rmsd attribute of HillCurve objects and reported in fit parameter summaries from CurveFits.

jbloom added 4 commits March 24, 2024 16:12
Add `HillCurve.rmsd` and fix calculation for `HillCurve.r2` in the edge
case when there is no variation in the data.
@jbloom jbloom merged commit bc76d62 into master Mar 25, 2024
1 check passed
@jbloom jbloom deleted the 55-r2-when-no-neut branch March 25, 2024 00:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R2 values of -inf when no neutralization is observed (i.e. a flat line at 1)
1 participant