goodness of fit looks at both RMSD and R2 #37
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
process_plate_curvefit_qc
in the YAML configuration, there is a new key calledgoodness_of_fit
and now bothmin_R2
(the minimum coefficient of determination) andmax_RMSD
(the maximum mean square deviation) for each curve fit are specified as keys under that. The curves are then filtered to retain only those that meet either of these criteria (so must fail both to be dropped). Addresses this issue and this issue. Alongside this change, thermsd
is now reported in key output files. Also, in the tabulation of failures,fails_min_R2
now becomesfails_goodness_of_fit
.min_R2
was a standalone key underprocess_plate_curvefit_qc
; nowgoodness_of_fit
is the required key andmin_R2
andmax_RMSD
are required keys under it.Added another plate (of H3N2 rather than H1N1) to the
test_example
to test some of the changes introduced in this version.