Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Better support for array serialization #8

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Better support for array serialization #8

merged 1 commit into from
Jan 15, 2024

Conversation

jborean93
Copy link
Owner

Ensure that any IList type like ArrayList or a Generic list is treated as a TOML array to align with how ConvertTo-Json works. Also properly deserializes a TOML array of array/table values into actual dotnet objects to provide a better deserialized value.

Fixes: #7

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (001d059) 89.26% compared to head (f95876c) 89.55%.

Files Patch % Lines
src/PSToml/ConvertFromToml.cs 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   89.26%   89.55%   +0.29%     
==========================================
  Files           3        3              
  Lines         149      249     +100     
  Branches       26       34       +8     
==========================================
+ Hits          133      223      +90     
- Misses          7       16       +9     
- Partials        9       10       +1     
Flag Coverage Δ
PS_5.1_x64_Windows ∅ <ø> (∅)
PS_7.2_x64_Linux 89.55% <93.02%> (+0.29%) ⬆️
PS_7.2_x64_Windows ∅ <ø> (∅)
PS_7.3_x64_Windows ∅ <ø> (∅)
PS_7.4_x64_Linux 89.55% <93.02%> (+0.29%) ⬆️
PS_7.4_x64_Windows ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Ensure that any IList type like ArrayList or a Generic list is treated
as a TOML array to align with how ConvertTo-Json works. Also properly
deserializes a TOML array of array/table values into actual dotnet
objects to provide a better deserialized value.
@jborean93 jborean93 merged commit 79124b5 into main Jan 15, 2024
10 checks passed
@jborean93 jborean93 deleted the arrays branch January 15, 2024 03:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConvertTo-Toml does not produce consistent content above a depth > 2
1 participant