Move back to using setup.cfg #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately due to some incompatibilities with pip and newer setuptools versions that introduced support for project definitions in the pyproject.toml this commit goes back to using the older setup.cfg definition. This ensures the project can be compiled from the sdist in more scenarios. At some point in the future this should be revisited when hosts come with newer pip versions.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately due to some incompatibilities with pip and newer setuptools versions that introduced support for project definitions in the pyproject.toml this commit goes back to using the older setup.cfg definition. This ensures the project can be compiled from the sdist in more scenarios. At some point in the future this should be revisited when hosts come with newer pip versions.