Raise original BadNetworkName error on DFS failure #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
==========================================
- Coverage 99.09% 99.07% -0.02%
==========================================
Files 24 24
Lines 5077 5082 +5
==========================================
+ Hits 5031 5035 +4
- Misses 46 47 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
When attempting to resolve the DFS path on a BadNetworkName error it may error with a DFS related error message. This error should be ignored if the error was stating DFS is unavailable. The whole check can also be avoided entirely if the server does not indicate it supports DFS in the capabilities it sends back.
jborean93
force-pushed
the
fs-error-dfs
branch
from
a4a84a9 to
fd6f673
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to resolve the DFS path on a BadNetworkName error it may error with a DFS related error message. This error should be ignored if the error was stating DFS is unavailable. The whole check can also be avoided entirely if the server does not indicate it supports DFS in the capabilities it sends back.
Fixes: #196