Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a module descriptor #111

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Add a module descriptor #111

merged 1 commit into from
Jun 7, 2024

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented Jun 7, 2024

This adds a module descriptor for the annotation module. The proposed module name is org.jboss.logging.annotations.

@dmlloyd dmlloyd requested a review from jamezp as a code owner June 7, 2024 13:38
Copy link
Member

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I supposed I should know this, but I don't. Does the annotation processor need one too?

@dmlloyd
Copy link
Member Author

dmlloyd commented Jun 7, 2024

I'm not sure that annotation processing with modules is very well-tested in Maven. It's worth some experimentation in the future, but I think it probably is OK to leave it as is for now. The tests pass without it.

@jamezp jamezp merged commit 346dbe1 into jboss-logging:main Jun 7, 2024
9 checks passed
@dmlloyd dmlloyd deleted the desc branch June 7, 2024 14:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants