Skip to content

Commit

Permalink
Restore behavior of #filter method
Browse files Browse the repository at this point in the history
  • Loading branch information
n-rodriguez committed Jun 29, 2017
1 parent ae8dc99 commit 07795fd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/ajax-datatables-rails/datatable/column.rb
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def cond
end

def filter(value)

This comment has been minimized.

Copy link
@natebird

natebird Jun 30, 2017

Contributor

If you are calling self then is it necessary to pass value anymore?

This comment has been minimized.

Copy link
@ajahongir

ajahongir Jun 30, 2017

Collaborator

yep, not need to pass value and I think we also can pass pass formatted value to cond
@view_column[:cond].call(self, formatted_value)

This comment has been minimized.

Copy link
@natebird

natebird Jun 30, 2017

Contributor

Ahh, that makes sense. Nice!

This comment has been minimized.

Copy link
@n-rodriguez

n-rodriguez Jul 6, 2017

Author Member

Ok

@view_column[:cond].call(value)
@view_column[:cond].call(self)
end

def source
Expand Down

0 comments on commit 07795fd

Please # to comment.