sanitizing data causes "undefined method `strip' for #<Array..." #325

epipheus · 2019-04-11T06:00:25Z

I'm getting an error in the browser when ajax-datatables-rails calls sanitize(data) here

When I track it down it doesn't like this line in Nokogiri (parent of Loofah)

          # This is a horrible hack, but I don't care
          if tags.strip =~ /^<body/i
            path = "/html/body"
          else
            path = "/html/body/node()"
          end

The text was updated successfully, but these errors were encountered:

…fferent things. Because datatables inherit from AjaxDatatablesRails::ActiveRecord which inherits from AjaxDatatablesRails::Base for some odd reason sanitize binds to ActionView's sanitize method which eventually gets to Loofah and Nokogiri which doesn't handle arrays and throws the error I reported in jbox-web#325 surprisingly even when you call self.sanitize it does not call the method in the same namespace and file!! because technically the sanitize function that we want is AjaxDatatablesRails::Base's function, to disabiguate we could either rename the function (and because I don't know what else calls it that seemed like a bad idea), or we could help disambiguate by being explicit about which super's method to call. The only way I saw to do this is to call it like this: AjaxDatatablesRails::Base.instance_method(:sanitize).bind(self).call(data). That may make for unreadable code to some, we could always define another method that then calls AjaxDatatablesRails::Base.instance_method(:sanitize).bind(self).call(data). Or if you have another way to fix, have at it. But this breaks in Ruby 2.4.0 and rails 5.2.3 for me without this change.

n-rodriguez · 2019-04-17T23:12:06Z

Closing the issue since you found the bug ;) thank you 👍

epipheus mentioned this issue Apr 11, 2019

sanitize(data) disabiguation #326

Merged

n-rodriguez closed this as completed Apr 17, 2019

n-rodriguez self-assigned this Apr 17, 2019

n-rodriguez added the bug label Apr 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sanitizing data causes "undefined method `strip' for #<Array..." #325

sanitizing data causes "undefined method `strip' for #<Array..." #325

epipheus commented Apr 11, 2019 •

edited

Loading

n-rodriguez commented Apr 17, 2019

sanitizing data causes "undefined method `strip' for #<Array..." #325

sanitizing data causes "undefined method `strip' for #<Array..." #325

Comments

epipheus commented Apr 11, 2019 • edited Loading

n-rodriguez commented Apr 17, 2019

epipheus commented Apr 11, 2019 •

edited

Loading