Rename additional_datas method as additional_data.
#251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data is already plural and singular form of it is +datum+ therefore naming a method as `additional_datas` is wrong. This commit renames the method without breaking change but with deprecating the old one.
meinac
force-pushed
the
correct_method_name
branch
from
3a61f34 to
acf0a17
Compare
natebird
approved these changes
Dec 6, 2017
|
Thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data is already plural and singular form of it is +datum+
therefore naming a method as
additional_datasis wrong.This commit renames the method without breaking change but
with deprecating the old one.