Skip to content
This repository has been archived by the owner on Jan 2, 2022. It is now read-only.

Commit

Permalink
feat: upgrade ui-caps to v4
Browse files Browse the repository at this point in the history
WDY-398
  • Loading branch information
jcmnunes committed Dec 13, 2020
1 parent 52d13c2 commit 40a379f
Show file tree
Hide file tree
Showing 14 changed files with 48 additions and 63 deletions.
1 change: 0 additions & 1 deletion frontend/.eslintcache

This file was deleted.

3 changes: 3 additions & 0 deletions frontend/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,6 @@ yarn-error.log*

# Docz
/.docz

# Eslint cache
.eslintcache
6 changes: 3 additions & 3 deletions frontend/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
],
"dependencies": {
"@binarycapsule/editor": "^1.1.1",
"@binarycapsule/ui-capsules": "^4.0.0",
"@binarycapsule/ui-capsules": "^4.0.1",
"@emotion/react": "^11.1.2",
"@emotion/styled": "^11.0.0",
"@nivo/core": "^0.67.0",
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/components/UserDropdown/UserDropdown.jsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { Button, Icon, Menu, MenuItem } from '@binarycapsule/ui-capsules';
import { Button, Menu, MenuItem } from '@binarycapsule/ui-capsules';
import { useDispatch } from 'react-redux';
import { useHistory } from 'react-router-dom';
import { logoutRequest } from '../../features/auth/Logout/Logout.actions';
Expand All @@ -24,12 +24,12 @@ const UserDropdown = () => {
>
<MenuItem
text="Settings"
leftAddon={<Icon icon="adjustments" size="18px" />}
leftIcon="adjustments"
onClick={() => history.push('/settings/account')}
/>
<MenuItem
text="Log out"
leftAddon={<Icon icon="login" size="18px" />}
leftIcon="login"
onClick={() => dispatch(logoutRequest())}
closeOnAction={false}
/>
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/features/day/PlanMenu/PlanMenu.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { Icon, IconButton, Menu, MenuItem } from '@binarycapsule/ui-capsules';
import { IconButton, Menu, MenuItem } from '@binarycapsule/ui-capsules';
import { useHistory, useParams } from 'react-router';
import { useMoveAll } from '../api/useMoveAll';
import { DayRouteParams } from '../dayTypes';
Expand All @@ -21,7 +21,7 @@ export const PlanMenu: React.FC<Props> = ({ planId }) => {
<>
<Menu trigger={Trigger} placement="right">
<MenuItem
leftAddon={<Icon icon="calendar" size="18px" />}
leftIcon="calendar"
onClick={() => {
moveAll({
to: 'schedule',
Expand Down
12 changes: 4 additions & 8 deletions frontend/src/features/day/TaskMenu/TaskMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,25 +38,21 @@ export const TaskMenu: React.FC<Props> = ({ dayId, sectionId, task, isPlan }) =>
{canRegisterTime ? (
<MenuItem
text="Register Time"
leftAddon={<Icon icon="clock" size="18px" />}
leftIcon="clock"
onClick={() => setShowRegisterTimeModal(true)}
/>
) : null}
<MenuItem
text="Rename"
leftAddon={<Icon icon="pencil" size="18px" />}
onClick={() => setShowRenameTaskModal(true)}
/>
<MenuItem text="Rename" leftIcon="pencil" onClick={() => setShowRenameTaskModal(true)} />
{canScheduleTask ? (
<MenuItem
text="Schedule"
leftAddon={<Icon icon="calendar" size="18px" />}
leftIcon="calendar"
onClick={() => setShowScheduleTaskDialog(true)}
/>
) : null}
<MenuItem
text="Delete"
leftAddon={<Icon icon="trash" size="18px" color="red.500" />}
leftAddon={<Icon icon="trash" color="error.500" size="18px" />}
onClick={() => setShowDeleteTaskDialog(true)}
/>
</Menu>
Expand Down
17 changes: 8 additions & 9 deletions frontend/src/features/day/dialogs/DeleteTaskDialog.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React from 'react';
import { Dialog } from '@binarycapsule/ui-capsules';
import { DialogAction } from '@binarycapsule/ui-capsules/dist/Dialog/Dialog';
import { Action, Dialog } from '@binarycapsule/ui-capsules';
import { useDeleteTask } from '../api/useDeleteTask';

interface Props {
Expand All @@ -22,16 +21,16 @@ export const DeleteTaskDialog: React.FC<Props> = ({ dayId, sectionId, taskId, on
onRequestClose();
};

const actions: DialogAction[] = [
const actions: Action[] = [
{
name: 'Cancel',
appearance: 'neutral',
action: onRequestClose,
text: 'Cancel',
variant: 'neutral',
onClick: onRequestClose,
},
{
name: 'Delete',
appearance: 'error',
action: deleteAction,
text: 'Delete',
variant: 'error',
onClick: deleteAction,
},
];

Expand Down
17 changes: 8 additions & 9 deletions frontend/src/features/day/dialogs/ScheduleTaskDialog.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React from 'react';
import { Dialog } from '@binarycapsule/ui-capsules';
import { DialogAction } from '@binarycapsule/ui-capsules/dist/Dialog/Dialog';
import { Action, Dialog } from '@binarycapsule/ui-capsules';
import { useHistory, useParams } from 'react-router';
import { ScheduleTaskVariables, useScheduleTask } from '../api/useScheduleTask';
import { DayRouteParams } from '../dayTypes';
Expand Down Expand Up @@ -38,16 +37,16 @@ export const ScheduleTaskDialog: React.FC<Props> = ({
return scheduleTask(scheduleTaskVariables);
};

const actions: DialogAction[] = [
const actions: Action[] = [
{
name: 'Cancel',
appearance: 'neutral',
action: onRequestClose,
text: 'Cancel',
variant: 'neutral',
onClick: onRequestClose,
},
{
name: 'Schedule',
appearance: 'primary',
action: scheduleTaskAction,
text: 'Schedule',
variant: 'primary',
onClick: scheduleTaskAction,
},
];

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export const LaunchTaskModal: React.FC<Props> = ({
};

return (
<Modal isOpen onRequestClose={onRequestClose} contentLabel="Modal - Launch task">
<Modal isOpen onRequestClose={onRequestClose} contentLabel="Modal - Launch task" size="small">
<ModalHeader>Choose a section:</ModalHeader>

<ModalCloseButton onClick={onRequestClose} />
Expand Down
4 changes: 0 additions & 4 deletions frontend/src/features/settings/Page/Scopes/Scopes.styles.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ export const ActionsTop = styled.div`
display: flex;
flex-direction: column;
> * + * {
margin-top: 8px;
}
@media (min-width: 600px) {
flex-direction: row;
align-items: center;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, { useState } from 'react';
import PropTypes from 'prop-types';
import { Icon, MenuItem } from '@binarycapsule/ui-capsules';
import { MenuItem } from '@binarycapsule/ui-capsules';
import ScopeCode from '../../../../../components/ScopeCode/ScopeCode';
import DotsMenu from '../../../../../components/DotsMenu/DotsMenu';
import EmptyScopesTable from '../EmptyScopesTable/EmptyScopesTable';
Expand All @@ -12,8 +12,8 @@ import { ScopeModal } from '../../../../day/modals/ScopeModal/ScopeModal';
const ScopesTable = ({ isArchived, scopes }) => {
const [selectedScope, setSelectedScope] = useState(null);

const [archiveScope] = useArchiveScope();
const [unarchiveScope] = useUnarchiveScope();
const [archiveScope, { isLoading: archiveScopeLoading }] = useArchiveScope();
const [unarchiveScope, { isLoading: unarchiveScopeLoading }] = useUnarchiveScope();

if (scopes.length === 0) {
return (
Expand All @@ -29,15 +29,12 @@ const ScopesTable = ({ isArchived, scopes }) => {
<ScopeCode scopeCode={scope.shortCode} onClick={() => setSelectedScope(scope)} />
<ScopeName onClick={() => setSelectedScope(scope)}>{scope.name}</ScopeName>
<DotsMenu>
<MenuItem
text="Edit"
leftAddon={<Icon icon="pencil" size="18px" />}
onClick={() => setSelectedScope(scope)}
/>
<MenuItem text="Edit" leftIcon="pencil" onClick={() => setSelectedScope(scope)} />

<MenuItem
text={isArchived ? 'Unarchive' : 'Archive'}
leftAddon={<Icon icon={isArchived ? 'arrow_up' : 'archive'} size="18px" />}
leftIcon={isArchived ? 'arrow_up' : 'archive'}
isLoading={archiveScopeLoading || unarchiveScopeLoading}
onClick={() => {
isArchived ? unarchiveScope(scope.id) : archiveScope(scope.id);
}}
Expand All @@ -47,6 +44,7 @@ const ScopesTable = ({ isArchived, scopes }) => {
</Row>
))}
</StyledScopesTable>

{!!selectedScope && (
<ScopeModal scope={selectedScope} closeModal={() => setSelectedScope(null)} />
)}
Expand Down
18 changes: 8 additions & 10 deletions frontend/src/features/userMenu/UserMenu.tsx
Original file line number Diff line number Diff line change
@@ -1,17 +1,18 @@
import React from 'react';
import { useDispatch } from 'react-redux';
import { useDispatch, useSelector } from 'react-redux';
import { useHistory, useParams } from 'react-router-dom';
import { Button, Icon, Menu, MenuItem } from '@binarycapsule/ui-capsules';
import { Button, Menu, MenuItem } from '@binarycapsule/ui-capsules';
import { logoutRequest } from '../auth/Logout/Logout.actions';
import { dayStateActions } from '../day/dayState/dayStateSlice';
import { DayRouteParams } from '../day/dayTypes';
import { isLoadingSelector as isLogoutLoadingSelector } from '../auth/Logout/Logout.selectors';

export const UserMenu = () => {
const { dayId } = useParams<DayRouteParams>();
const history = useHistory();
const dispatch = useDispatch();

// const isLogoutLoading = useSelector(isLogoutLoadingSelector);
const isLogoutLoading = useSelector(isLogoutLoadingSelector);

const showSchedule = () => {
dispatch(dayStateActions.showSchedule());
Expand All @@ -29,22 +30,19 @@ export const UserMenu = () => {
/>
}
>
<MenuItem
text="Schedule"
leftAddon={<Icon icon="calendar" size="18px" />}
onClick={showSchedule}
/>
<MenuItem text="Schedule" leftIcon="calendar" onClick={showSchedule} />

<MenuItem
text="Settings"
leftAddon={<Icon icon="cog" size="18px" />}
leftIcon="cog"
onClick={() => history.push(`/settings/account${dayId ? `/${dayId}` : ''}`)}
/>

<MenuItem
text="Log out"
leftAddon={<Icon icon="logout" size="18px" />}
leftIcon="logout"
onClick={() => dispatch(logoutRequest())}
isLoading={isLogoutLoading}
closeOnAction={false}
/>
</Menu>
Expand Down
3 changes: 0 additions & 3 deletions frontend/src/helpers/settings.js

This file was deleted.

0 comments on commit 40a379f

Please # to comment.