Ensure predictable tcp by sorting endpoints #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamic update code relies on comparing tcp services structs in order to verify whether any tcp service has changed or not, and if so, haproxy need to be restarted. Endpoint list is the only tcp data that might lead to differences in the case the same values are present, but in distinct order. Because of that we're applying a sort in order to generate predictable, hence comparable results.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic update code relies on comparing tcp services structs in order to verify whether any tcp service has changed or not, and if so, haproxy need to be restarted. Endpoint list is the only tcp data that might lead to differences in the case the same values are present, but in distinct order. Because of that we're applying a sort in order to generate predictable, hence comparable results.