Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Multus Thick plugin Chart #5

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Multus Thick plugin Chart #5

wants to merge 5 commits into from

Conversation

jdambly-ns
Copy link
Owner

Summary

This PR introduces a new Helm chart specifically for the multus-thick plugin. In addition to the Helm chart, it includes a GitHub Action for automated testing and linting.

Key Changes

  1. New Helm Chart for multus-thick:
    • This chart is separate from the existing multus chart to simplify the structure and avoid the complexity of using conditional (if) statements within a single chart.
    • The chart is designed to focus solely on the deployment of the multus-thick plugin, making it easier to maintain and customize without handling multiple plugin configurations in one place.
  2. GitHub Action for Testing/Linting:
    • Adds a CI workflow using GitHub Actions to automatically run Helm linting and testing on each PR or push.
    • Ensures that the chart adheres to best practices and doesn't introduce any issues during development.

Rationale

  • Simpler Chart Structure: By breaking out the multus-thick plugin into its own Helm chart, the chart logic is cleaner and easier to maintain. This avoids the need for complex if conditions that would otherwise be required to handle both multus-thick and multus-thin in a single chart.
  • Improved CI/CD: The addition of GitHub Actions for linting and testing ensures that the chart is continuously validated against best practices and that any issues are caught early during the development process.

Testing & Validation

  • The GitHub Action included in this PR automatically runs Helm linting and basic testing, ensuring that the chart is properly validated before merging.
  • Manual testing has also been done to ensure that the multus-thick plugin deploys correctly in various environments.

Next Steps

  • Future iterations may include additional testing or enhancements based on feedback, but the separation of the thick and thin plugins into their own charts should reduce complexity moving forward.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant