New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Proposed fix 2/2 for #388 #437

Closed

abloomston wants to merge 1 commit into jdorn:master from abloomston:issue338_smaller

abloomston commented Jun 16, 2015

This proposed fix for #388 involves replicating the bare minimum logic from math.js.

Advantages:

Minimal changes to json-editor

Disadvantages:

Uncertain if this method of including derivative code properly follows the licensing restrictions
Copy/Paste Programming is ugly


          proposed fix for jdorn#388 using math.js

5eb711f

* stripped minimal logic from math.js fp arithmetic for fixing jdorn#388

abloomston mentioned this pull request

multipleOf erroneous validation failure #388

Closed

Author

abloomston commented Jul 3, 2015

This proposed fix does not work for e.g. 3.57 multipleOf 0.01. PR #436 now works for it, though.

abloomston closed this

abloomston mentioned this pull request

Proposed fix 1/2 for #388 #436

Closed

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet