Support SQLAlchemy 1.3 deprecated threadlocal strategy #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQLAlchemy 1.3 has deprecated the threadlocal engine strategy. This change has the side effect of making the Engine.contextual_connect() method private, which interferes with our mocking. Depending on the installed version of SQLAlchemy, mock this method differently. See: - https://docs.sqlalchemy.org/en/latest/changelog/migration_13.html
jeancochrane
force-pushed
the
jfc/bugfix/sqlalchemy-1.3-support
branch
from
c78cc35 to
a10b23c
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SQLAlchemy 1.3 has deprecated the threadlocal engine strategy. This change has the side effect of making the
Engine.contextual_connect()method private, which interferes with our mocking.Depending on the installed version of SQLAlchemy, mock this method differently.
See: