Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix self signed certificate compatibility #18

Merged

Conversation

sonnyp
Copy link

@sonnyp sonnyp commented May 27, 2021

@sonnyp
Copy link
Author

sonnyp commented May 27, 2021

Unfortunately #17 is silent to the user and because of the current design it's difficult to make it explicit.

Ideally chalet would self-heal in this case but that would introduce quite a lot of complexity.

Maybe I can add a note to the README.md or create an issue that you can pin ?

What do you think is best?

@sonnyp
Copy link
Author

sonnyp commented May 27, 2021

Self signed certificate work fine (as in browser will let me proceed) with these new settings:

Chromium 90 / Fedora 34
Screenshot from 2021-05-27 14-34-59

Firefox Developer Edition 89.0b15 / Fedora 34
Screenshot from 2021-05-27 14-34-36

@jeansaad
Copy link
Owner

jeansaad commented Oct 6, 2021

@sonnyp, thanks for putting in the time for this. I actually steer clear of using the self-signed certificates in chalet, mostly cause they cause a headache with things like Safari.

My personal setup is Caddy + dnsmasq, with a delegation to chalet for configurable command line reverse proxy. Probably not the easiest setup, but I wonder if there is a place here where chalet can improve on.

I'm all for adding a note in the README.md for those that want to re-generate their certificates. It should be as simple as deleting the certs and it will get re-built.

@jeansaad
Copy link
Owner

jeansaad commented Oct 6, 2021

Alternatively we can write an FAQ and link it in the README, cause this issue probably will happen when a self-signed certificate expires.

Edit: Created one here that u can link to https://github.com/jeansaad/chalet/wiki/Frequently-Asked-Questions#what-can-i-do-if-my-certificate-expires-or-i-have-a-certificate-problem

@sonnyp
Copy link
Author

sonnyp commented Oct 6, 2021

This PR solves a different problem than self signed certificates expiring.

@jeansaad
Copy link
Owner

jeansaad commented Oct 6, 2021

Yes, fair enough; however, the solution to regenerate the certs is the same, no?

@sonnyp sonnyp force-pushed the fix-self-signed-certificate-generation branch from 8a77103 to db28313 Compare October 20, 2021 07:47
@sonnyp
Copy link
Author

sonnyp commented Oct 20, 2021

I understand now you were talking about letting users know how to "heal" the problem.

I've added an entry in the FAQ.

@jeansaad jeansaad merged commit d8bfd18 into jeansaad:master Oct 20, 2021
@jeansaad
Copy link
Owner

@sonnyp, this has been merged and released! Thanks for the contribution!

@sonnyp sonnyp deleted the fix-self-signed-certificate-generation branch October 26, 2021 09:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chalet does not work
2 participants