Add vite example to ReadMe #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalpp
commented
Jul 11, 2023
| @@ -99,6 +99,7 @@ chalet add 'python -m SimpleHTTPServer $PORT' # static file server (Py | |||
| chalet add 'php -S 127.0.0.1:$PORT' # PHP | |||
| chalet add 'docker-compose up' # docker-compose | |||
| chalet add 'python manage.py runserver 127.0.0.1:$PORT' # Django | |||
| chalet add 'npm run dev -- --port $PORT' # Vite Dev Server | |||
There was a problem hiding this comment.
this could also be vite --port $PORT but I think most vite users would be using npm run dev. That requires the interim -- which might trip up some users as well, so helpful to have an example in this form.
jeansaad
approved these changes
Nov 10, 2023
|
Thank you for this PR! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I struggled with getting Vite working in chalet and finally figured out that it needed the $PORT var included in the cmd as shown in some of the other examples. Since Vite is pretty popular these days I thought it was worth adding an explicit example in the ReadMe.