New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

table: RowPainterWithAttributes; addresses #345 #346

Merged

jedib0t merged 2 commits into main from table-row-painter

Dec 9, 2024

Owner

jedib0t commented Dec 9, 2024

Proposed Changes

Allow SetRowPainter to take functions with 2 different signatures
- RowPainter with the original func(table.Row) text.Colors
- RowPainterWithAttributes with func(table.Row, table.RowAttributes) text.Colors
  - RowAttributes carry additional properties of the row back to the painter

jedib0t added 2 commits

December 8, 2024 21:39


          table: RowPainterWithAttributes; addresses #345

a20a732


          minor fixes, addl comments

21adada

sonarqubecloud bot commented Dec 9, 2024

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

coveralls commented Dec 9, 2024

Pull Request Test Coverage Report for Build 12239882869

Details

65 of 65 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 12101145541:	0.0%
Covered Lines:	3801
Relevant Lines:	3801

💛 - Coveralls

jedib0t merged commit 612678d into main

6 checks passed

jedib0t deleted the table-row-painter branch

December 9, 2024 16:28

jedib0t added a commit that referenced this pull request


          table: RowPainterWithAttributes; addresses #345 (#346)

9dfb82e

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet